Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about limits of opened perf event files. #2695

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

Creatone
Copy link
Collaborator

@Creatone Creatone commented Oct 9, 2020

Signed-off-by: Paweł Szulik pawel.szulik@intel.com

@k8s-ci-robot
Copy link
Collaborator

Hi @Creatone. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@iwankgb
Copy link
Collaborator

iwankgb commented Oct 9, 2020

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 29, 2020

@bobbypage and this one too.
I know I'm sending lots of similar comments but these fixes were in limbo for a while.

@Creatone
Copy link
Collaborator Author

@bobbypage nice to have this in docs.

docs/runtime_options.md Outdated Show resolved Hide resolved
@@ -152,6 +152,9 @@ Core perf events can be exposed on Prometheus endpoint per CPU or aggregated by
- `--disable_metrics="percpu"` - core perf events are aggregated
- `--disable_metrics=""` - core perf events are exposed per CPU.

It's possible to get "too many opened files" error when a lof of perf events are exposed per CPU. This happens because of passing system limits.
Try to increase it with `ulimit -n <value>`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you note that ulimit -n <value> increases max number of file descriptions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it good now?

Copy link
Collaborator

@bobbypage bobbypage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small nits, thanks for updating doc!

@bobbypage bobbypage self-assigned this Oct 30, 2020
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
@Creatone Creatone force-pushed the too-many-opened-perf-files branch from d8a8a3f to 7b61c25 Compare November 2, 2020 17:22
@Creatone Creatone requested a review from bobbypage November 3, 2020 08:32
Copy link
Collaborator

@bobbypage bobbypage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bobbypage bobbypage merged commit 0d00708 into google:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants