-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about limits of opened perf event files. #2695
Conversation
Hi @Creatone. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@bobbypage and this one too. |
@bobbypage nice to have this in docs. |
docs/runtime_options.md
Outdated
@@ -152,6 +152,9 @@ Core perf events can be exposed on Prometheus endpoint per CPU or aggregated by | |||
- `--disable_metrics="percpu"` - core perf events are aggregated | |||
- `--disable_metrics=""` - core perf events are exposed per CPU. | |||
|
|||
It's possible to get "too many opened files" error when a lof of perf events are exposed per CPU. This happens because of passing system limits. | |||
Try to increase it with `ulimit -n <value>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you note that ulimit -n <value>
increases max number of file descriptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it good now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two small nits, thanks for updating doc!
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
d8a8a3f
to
7b61c25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Paweł Szulik pawel.szulik@intel.com